linux-kernel - RE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AM4PR0501MB21946528385296CCEEBFEB1AB1390@AM4PR0501MB2194.eurprd05.prod.outlook.com>
Date:   Fri, 1 Dec 2017 11:11:03 +0000
From:   Oleksandr Shamray <oleksandrs@...lanox.com>
To:     'Kun Yi' <kunyi@...gle.com>
CC:     "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "arnd@...db.de" <arnd@...db.de>,
        system-sw-low-level <system-sw-low-level@...lanox.com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        Vadim Pasternak <vadimp@...lanox.com>,
        "linux-api@...r.kernel.org" <linux-api@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "openocd-devel-owner@...ts.sourceforge.net" 
        <openocd-devel-owner@...ts.sourceforge.net>,
        "mec@...ut.net" <mec@...ut.net>, Jiri Pirko <jiri@...lanox.com>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "tklauser@...tanz.ch" <tklauser@...tanz.ch>,
        "mchehab@...nel.org" <mchehab@...nel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
 families JTAG master driver

> -----Original Message-----
> From: Kun Yi [mailto:kunyi@...gle.com]
> Sent: Thursday, November 30, 2017 12:51 AM
> To: Oleksandr Shamray <oleksandrs@...lanox.com>
> Cc: gregkh@...uxfoundation.org; arnd@...db.de; system-sw-low-level
> <system-sw-low-level@...lanox.com>; devicetree@...r.kernel.org;
> jiri@...nulli.us; Vadim Pasternak <vadimp@...lanox.com>; linux-
> api@...r.kernel.org; OpenBMC Maillist <openbmc@...ts.ozlabs.org>; linux-
> kernel@...r.kernel.org; openocd-devel-owner@...ts.sourceforge.net;
> mec@...ut.net; Jiri Pirko <jiri@...lanox.com>; robh+dt@...nel.org; linux-
> serial@...r.kernel.org; tklauser@...tanz.ch; mchehab@...nel.org;
> davem@...emloft.net; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [patch v12 2/4] drivers: jtag: Add Aspeed SoC 24xx and 25xx
> families JTAG master driver
> 
> Thanks for working on the driver, Oleksandr. I gave this a try on a board with
> Aspeed 2520. One question below:
> 
> On Tue, Nov 14, 2017 at 8:11 AM, Oleksandr Shamray
> <oleksandrs@...lanox.com> wrote:
> > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller.
> >
> > Driver implements the following jtag ops:
> > - freq_get;
> > - freq_set;
> > - status_get;
> > - idle;
> > - xfer;
> >

[..]

> > +
> > +static const struct jtag_ops aspeed_jtag_ops = {
> > +       .freq_get = aspeed_jtag_freq_get,
> > +       .freq_set = aspeed_jtag_freq_set,
> > +       .status_get = aspeed_jtag_status_get,
> > +       .idle = aspeed_jtag_idle,
> > +       .xfer = aspeed_jtag_xfer,
> > +       .mode_set = aspeed_jtag_mode_set };
> > +
> > +static int aspeed_jtag_probe(struct platform_device *pdev) {
> > +       struct aspeed_jtag *aspeed_jtag;
> > +       struct jtag *jtag;
> > +       int err;
> > +
> > +       if (!of_device_is_compatible(pdev->dev.of_node,
> > + "aspeed,aspeed-jtag"))
> 
> Should this be "aspeed,ast2400-jtag"/"aspeed,ast2500-jtag" as specified in the
> compatible string below?
> 

Yes


> > +               return -ENOMEM;
> > +
> > +       jtag = jtag_alloc(sizeof(*aspeed_jtag), &aspeed_jtag_ops);
> > +       if (!jtag)
> > +               return -ENODEV;
> > +
> > +       platform_set_drvdata(pdev, jtag);
> > +       aspeed_jtag = jtag_priv(jtag);
> > +       aspeed_jtag->dev = &pdev->dev;
> > +
 
[..]

> > +
> > +MODULE_AUTHOR("Oleksandr Shamray <oleksandrs@...lanox.com>");
> > +MODULE_DESCRIPTION("ASPEED JTAG driver"); MODULE_LICENSE("GPL
> v2");
> > --
> > 1.7.1
> >
> --
> Regards,
> Kun

Thanks.

BR
Oleksandr Shamray