linux-kernel - Re: [PATCH v2 35/35] dt-bindings: timer: Add andestech atcpit100 timer binding doc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYuo88qeEznKxVojYofV4YTGu6AOgan-2GPYS9qZCVxZA@mail.gmail.com>
Date:   Fri, 1 Dec 2017 13:19:25 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Greentime Hu <green.hu@...il.com>
Cc:     greentime@...estech.com,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Marc Zyngier <marc.zyngier@....com>,
        Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org,
        deanbo422@...il.com,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Al Viro <viro@...iv.linux.org.uk>,
        David Howells <dhowells@...hat.com>,
        Will Deacon <will.deacon@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        linux-serial@...r.kernel.org, Rick Chen <rickchen36@...il.com>
Subject: Re: [PATCH v2 35/35] dt-bindings: timer: Add andestech atcpit100
 timer binding doc

On Mon, Nov 27, 2017 at 1:28 PM, Greentime Hu <green.hu@...il.com> wrote:

> From: Rick Chen <rickchen36@...il.com>
>
> Add a document to describe Andestech atcpit100 timer and
> binding information.
>
> Signed-off-by: Rick Chen <rickchen36@...il.com>
> Acked-by: Rob Herring <robh@...nel.org>
> Signed-off-by: Greentime Hu <green.hu@...il.com>

Thanks for submitting this interesting architecture!

(...)

> +Required properties:
> +- compatible   : Should be "andestech,atcpit100"
> +- reg          : Address and length of the register set
> +- interrupts   : Reference to the timer interrupt
> +- clocks : a clock to provide the tick rate for "andestech,atcpit100"
> +- clock-names : should be "PCLK" for the external tick timer.

This text seem wrong. PCLK is the internal timer, right? "PCLK" is
"peripheral clock" (I hope) and that comes from the bus.

Consider also adding an optional "EXTCLK" already now, since it is
evident from the driver that this is also supported.

Yours,
Linus Walleij