linux-kernel - Re: [PATCHv1 08/14] drm/omap: panel-dsi-cm: fix driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290ca0f-4fc8-89ca-f943-8420f2bdeaff@ti.com>
Date:   Fri, 1 Dec 2017 14:28:44 +0200
From:   Tomi Valkeinen <tomi.valkeinen@...com>
To:     Sebastian Reichel <sebastian.reichel@...labora.co.uk>,
        Sebastian Reichel <sre@...nel.org>,
        Tony Lindgren <tony@...mide.com>
CC:     Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        <dri-devel@...ts.freedesktop.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv1 08/14] drm/omap: panel-dsi-cm: fix driver

Hi,

On 24/07/17 20:33, Sebastian Reichel wrote:
> From: Tony Lindgren <tony@...mide.com>
> 
> This adds support for get_timings() and check_timings()
> to get the driver working and properly initializes the
> timing information from DT.

I don't know if it matters much, but the timings added to dts in the
following patches are mostly not used, and do not make sense for DSI
command mode panel. Only hactive and vactive are used. But if full video
timings are present in the dts, then I think it would be good to have
the timings correct, so that also pixel clock is defined, and the
timings would produce 60Hz refresh rate.

 Tomi

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki