linux-kernel - Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201124935.qgqclyoatnnph63p@sirena.org.uk>
Date:   Fri, 1 Dec 2017 12:49:35 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Erick Chen <erick.chen@...eadtrum.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, lgirdwood@...il.com,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, baolin.wang@...aro.org,
        baolin.wang@...eadtrum.com
Subject: Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support
 Spreadtrum SC2731 PMIC

On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote:
> On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen <erick.chen@...eadtrum.com> wrote:

> I think that per Linus, and Thomas doc patches for SPDX ids this
> should be instead either:

> > +// SPDX-License-Identifier: GPL-2.0
> > + // Copyright (c) 2017 Spreadtrum Communications Inc.

> or at least this with the id on the first and the // comment style

> > +// SPDX-License-Identifier: GPL-2.0

Are you saying SPDX requires C++ style comments?  That seems totally
broken.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)