linux-kernel - Re: Support TrackStick of Thinkpad L570

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANwerB1NVueMgpaO1eFLMsfmaSmTmNaQmcufjY5sr_gNhy1RYQ@mail.gmail.com>
Date:   Sat, 2 Dec 2017 00:26:40 +1100
From:   Jonathan Liu <net147@...il.com>
To:     Masaki Ota <012nexus@...il.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        benjamin.tissoires@...hat.com, pali.rohar@...il.com,
        aaron.ma@...onical.com, jaak@...tioja.ee,
        Masaki Ota <masaki.ota@...alps.com>,
        linux-input@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: Support TrackStick of Thinkpad L570

Hi Masaki,

On 29 November 2017 at 19:33, Masaki Ota <012nexus@...il.com> wrote:
> From: Masaki Ota <masaki.ota@...alps.com>
> - The issue is that Thinkpad L570 TrackStick does not work. Because the main interface of Thinkpad L570 device is SMBus, so ALPS overlooked PS2 interface Firmware setting of TrackStick. The detail is that TrackStick otp bit is disabled.
> - Add the code that checks 0xD7 address value. This value is device number information, so we can identify the device by checking this value.
> - If we check 0xD7 value, we need to enable Command mode and after check the value we need to disable Command mode, then we have to enable the device(0xF4 command).
> - Thinkpad L570 device number is 0x0C or 0x1D. If it is TRUE, enable ALPS_DUALPOINT flag.
>
> Signed-off-by: Masaki Ota <masaki.ota@...alps.com>
> ---
>  drivers/input/mouse/alps.c | 24 +++++++++++++++++++++---
>  1 file changed, 21 insertions(+), 3 deletions(-)

Tested-by: Jonathan Liu <net147@...il.com>

This fixes trackstick and physical left/middle/right mouse buttons
above touchpad on Lenovo ThinkPad E570p laptop for me.

Regards,
Jonathan