linux-kernel - Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2017 14:39:42 +0100
From:   Philippe Ombredanne <pombredanne@...b.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Erick Chen <erick.chen@...eadtrum.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>, lgirdwood@...il.com,
        LKML <linux-kernel@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, baolin.wang@...aro.org,
        baolin.wang@...eadtrum.com,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support
 Spreadtrum SC2731 PMIC

Mark,

On Fri, Dec 1, 2017 at 1:49 PM, Mark Brown <broonie@...nel.org> wrote:
> On Fri, Dec 01, 2017 at 10:13:27AM +0100, Philippe Ombredanne wrote:
>> On Fri, Dec 1, 2017 at 9:58 AM, Erick Chen <erick.chen@...eadtrum.com> wrote:
>
>> I think that per Linus, and Thomas doc patches for SPDX ids this
>> should be instead either:
>
>> > +// SPDX-License-Identifier: GPL-2.0
>> > + // Copyright (c) 2017 Spreadtrum Communications Inc.
>
>> or at least this with the id on the first and the // comment style
>
>> > +// SPDX-License-Identifier: GPL-2.0
>
> Are you saying SPDX requires C++ style comments?  That seems totally
> broken.

In can understand your point, but for reference please check Linus
[1][2][3], Thomas[4] and Greg[5] comments on the topic.

I am just a lowly messenger and even though I personally agree with
Linus points and taste in this area, my weightless voice does not
matter.

CC: Linus, Greg and Thomas

[1] https://lkml.org/lkml/2017/11/2/715
[2] https://lkml.org/lkml/2017/11/25/125
[3] https://lkml.org/lkml/2017/11/25/133
[4] https://lkml.org/lkml/2017/11/2/805
[5] https://lkml.org/lkml/2017/10/19/165
-- 
Cordially
Philippe Ombredanne