linux-kernel - Re: [PATCH v2 4/7] media: usb: add SPDX identifiers to some code I wrote

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20171201143239.3e64t23vciv52jo4@paasikivi.fi.intel.com>
Date:   Fri, 1 Dec 2017 16:32:40 +0200
From:   Sakari Ailus <sakari.ailus@...ux.intel.com>
To:     Mauro Carvalho Chehab <mchehab@...pensource.com>
Cc:     Linux Media Mailing List <linux-media@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...radead.org>,
        linux-kernel@...r.kernel.org, Sean Young <sean@...s.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Colin Ian King <colin.king@...onical.com>,
        Andi Shyti <andi.shyti@...sung.com>,
        David Härdeman <david@...deman.nu>,
        Bhumika Goyal <bhumirks@...il.com>,
        Markus Elfring <elfring@...rs.sourceforge.net>,
        Arvind Yadav <arvind.yadav.cs@...il.com>,
        Julia Lawall <Julia.Lawall@...6.fr>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Santosh Kumar Singh <kumar.san1093@...il.com>
Subject: Re: [PATCH v2 4/7] media: usb: add SPDX identifiers to some code I
 wrote

Bom dia!

On Fri, Dec 01, 2017 at 11:59:33AM -0200, Mauro Carvalho Chehab wrote:
> Em Fri, 1 Dec 2017 15:52:55 +0200
> Sakari Ailus <sakari.ailus@...ux.intel.com> escreveu:
> 
> > Hi Mauro,
> > 
> > On Fri, Dec 01, 2017 at 11:47:10AM -0200, Mauro Carvalho Chehab wrote:
> > > diff --git a/drivers/media/usb/au0828/au0828-input.c b/drivers/media/usb/au0828/au0828-input.c
> > > index af68afe085b5..832ed9f25784 100644
> > > --- a/drivers/media/usb/au0828/au0828-input.c
> > > +++ b/drivers/media/usb/au0828/au0828-input.c
> > > @@ -1,21 +1,10 @@
> > > -/*
> > > -  handle au0828 IR remotes via linux kernel input layer.
> > > -
> > > -   Copyright (C) 2014 Mauro Carvalho Chehab <mchehab@...sung.com>
> > > -   Copyright (c) 2014 Samsung Electronics Co., Ltd.
> > > -
> > > -  Based on em28xx-input.c.
> > > -
> > > -  This program is free software; you can redistribute it and/or modify
> > > -  it under the terms of the GNU General Public License as published by
> > > -  the Free Software Foundation; either version 2 of the License, or
> > > -  (at your option) any later version.
> > > -
> > > -  This program is distributed in the hope that it will be useful,
> > > -  but WITHOUT ANY WARRANTY; without even the implied warranty of
> > > -  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > > -  GNU General Public License for more details.
> > > - */
> > > +// SPDX-License-Identifier: GPL-2.0+
> > > +// handle au0828 IR remotes via linux kernel input layer.
> > > +//
> > > +// Copyright (c) 2014 Mauro Carvalho Chehab <mchehab@...sung.com>
> > > +// Copyright (c) 2014 Samsung Electronics Co., Ltd.
> > > +//
> > > +// Based on em28xx-input.c.  
> > 
> > Is the intention really to use C++ comments? 
> 
> Yes.
> 
> > I see that the SPDX license identifiers elsewhere use C comments.
> 
> Linus defined this way:
> 
> 	https://www.spinics.net/lists/linux-xfs/msg13289.html

Right. Although you could suspect this to be from someone just pretending
to be Linus. :-D Anyway,

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus
sakari.ailus@...ux.intel.com