linux-kernel - Re: [PATCH 1/1] at24: Fix I²C device selection for runtime PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGngYiUktfXOU64Uo-O=01OWJrT8fQ7icxS6m4mQO+6UAkGUsA@mail.gmail.com>
Date:   Fri, 1 Dec 2017 10:20:41 -0500
From:   Sven Van Asbroeck <thesven73@...il.com>
To:     Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc:     linux-i2c@...r.kernel.org, svendev@...x.com,
        linux-kernel@...r.kernel.org, divagar.mohandass@...el.com,
        brgl@...ev.pl
Subject: Re: [PATCH 1/1] at24: Fix I²C device selection for runtime PM

Thank you, it fixes the issue on the multi-address eeprom that I have access to.

Tested-by: Sven Van Asbroeck on a 24AA16/24LC16B <svendev@...x.com>

One very minor remark:

+       struct device *dev = &at24->client[0]->dev;

It is sufficiently clear to others (and us a few months down the line)
why we are
using only client[0] for power management? Could it benefit from a separate
function with comments?

struct device *dev = get_pm_device(at24);

static struct device *get_pm_device(struct at24_data *at24)
{
    /* explain why we use client[0] and not any of the dummies */
    return &at24->client[0]->dev;
}