linux-kernel - Re: [PATCH] power: supply: charger-manager: Fix typo in condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171201152918.qjmo6i5bk3ij5myj@earth>
Date:   Fri, 1 Dec 2017 16:29:18 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     raitosyo@...il.com
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] power: supply: charger-manager: Fix typo in condition

Hi,

On Tue, Nov 21, 2017 at 01:27:12PM +0900, raitosyo@...il.com wrote:
> From: Ryosuke Saito <raitosyo@...il.com>
> 
> Should be discharging_max_duration_ms, not charging_max_duration_ms.
> 
> Signed-off-by: Ryosuke Saito <raitosyo@...il.com>
> ---

Thanks, queued.

-- Sebastian

>  drivers/power/supply/charger-manager.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/power/supply/charger-manager.c b/drivers/power/supply/charger-manager.c
> index 6502fa7..1de4b44 100644
> --- a/drivers/power/supply/charger-manager.c
> +++ b/drivers/power/supply/charger-manager.c
> @@ -578,7 +578,7 @@ static int check_charging_duration(struct charger_manager *cm)
>  	} else if (is_ext_pwr_online(cm) && !cm->charger_enabled) {
>  		duration = curr - cm->charging_end_time;
>  
> -		if (duration > desc->charging_max_duration_ms &&
> +		if (duration > desc->discharging_max_duration_ms &&
>  				is_ext_pwr_online(cm)) {
>  			dev_info(cm->dev, "Discharging duration exceed %ums\n",
>  				 desc->discharging_max_duration_ms);
> -- 
> 2.9.5
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)