linux-kernel - Re: [PATCH] HSI: cmt_speech: use timespec64 instead of timespec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171201153555.ab4iwigjgbhq6djz@earth>
Date:   Fri, 1 Dec 2017 16:35:55 +0100
From:   Sebastian Reichel <sebastian.reichel@...labora.co.uk>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     y2038@...ts.linaro.org,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        Ingo Molnar <mingo@...nel.org>,
        Dave Jiang <dave.jiang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] HSI: cmt_speech: use timespec64 instead of timespec

Hi Arnd,

On Mon, Nov 27, 2017 at 12:42:34PM +0100, Arnd Bergmann wrote:
> struct timespec should no longer be used because of the y2038
> overflow problem. This code does not suffer from the overflow,
> but it's trivial to change it to use timespec64 without changing
> the interface, so let's do that.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Thanks, queued.

-- Sebastian

>  drivers/hsi/clients/cmt_speech.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hsi/clients/cmt_speech.c b/drivers/hsi/clients/cmt_speech.c
> index 727f968ac1cb..05b80723d39d 100644
> --- a/drivers/hsi/clients/cmt_speech.c
> +++ b/drivers/hsi/clients/cmt_speech.c
> @@ -451,11 +451,11 @@ static void cs_hsi_read_on_control_complete(struct hsi_msg *msg)
>  	dev_dbg(&hi->cl->device, "Read on control: %08X\n", cmd);
>  	cs_release_cmd(msg);
>  	if (hi->flags & CS_FEAT_TSTAMP_RX_CTRL) {
> -		struct timespec tspec;
> +		struct timespec64 tspec;
>  		struct cs_timestamp *tstamp =
>  			&hi->mmap_cfg->tstamp_rx_ctrl;
>  
> -		ktime_get_ts(&tspec);
> +		ktime_get_ts64(&tspec);
>  
>  		tstamp->tv_sec = (__u32) tspec.tv_sec;
>  		tstamp->tv_nsec = (__u32) tspec.tv_nsec;
> -- 
> 2.9.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)