linux-kernel - Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201020604.etfzccuwomxgcwmg@rob-hp-laptop>
Date:   Thu, 30 Nov 2017 20:06:04 -0600
From:   Rob Herring <robh@...nel.org>
To:     sean.wang@...iatek.com
Cc:     matthias.bgg@...il.com, mark.rutland@....com,
        devicetree@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] mmc: dt-bindings: add mmc support to MT7623 SoC

On Wed, Nov 29, 2017 at 06:10:35PM +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> Add the devicetree binding for MT7623 SoC using MT2701 as the fallback.
> 
> Cc: devicetree@...r.kernel.org
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  Documentation/devicetree/bindings/mmc/mtk-sd.txt | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> index 72d2a73..1732588 100644
> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
> @@ -12,6 +12,8 @@ Required properties:
>  	"mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
>  	"mediatek,mt2701-mmc": for mmc host ip compatible with mt2701
>  	"mediatek,mt2712-mmc": for mmc host ip compatible with mt2712
> +	"mediatek,mt7623-mmc",
> +	"mediatek,mt2701-mmc": for mmc host ip compatible with mt7623

Those should be on 1 line ideally.

BTW, I find "for mmc host ip compatible with mt7623" to be mostly 
redundant.

Either way,

Acked-by: Rob Herring <robh@...nel.org>


>  - reg: physical base address of the controller and length
>  - interrupts: Should contain MSDC interrupt number
>  - clocks: Should contain phandle for the clock feeding the MMC controller
> -- 
> 2.7.4
>