linux-kernel - Re: [PATCH 2/9] dt-bindings: arm: brcmstb: Correct BIUCTRL node documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171201022134.ua2a7jc5n44m4qb2@rob-hp-laptop>
Date:   Thu, 30 Nov 2017 20:21:34 -0600
From:   Rob Herring <robh@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     bcm-kernel-feedback-list@...adcom.com,
        Mark Rutland <mark.rutland@....com>,
        Brian Norris <computersforpeace@...il.com>,
        Gregory Fong <gregory.0xf0@...il.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/9] dt-bindings: arm: brcmstb: Correct BIUCTRL node
 documentation

On Wed, Nov 29, 2017 at 12:18:42PM -0800, Florian Fainelli wrote:
> Correct the Device Tree bindings for the HIF_CPUBIUCTRL node whose
> compatible string is actually brcm,bcm<chip-id>-cpu-biu-ctrl. Also
> document in the binding the fallback property
> ("brcm,brcmstb-cpu-biu-ctrl") and update the example accordingly.
> 
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>  .../devicetree/bindings/arm/bcm/brcm,brcmstb.txt   | 22 ++++++++++++----------
>  1 file changed, 12 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> index 790e6b0b8306..05be8d1f7be6 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> +++ b/Documentation/devicetree/bindings/arm/bcm/brcm,brcmstb.txt
> @@ -17,21 +17,23 @@ Further, syscon nodes that map platform-specific registers used for general
>  system control is required:
>  
>      - compatible: "brcm,bcm<chip_id>-sun-top-ctrl", "syscon"
> -    - compatible: "brcm,bcm<chip_id>-hif-cpubiuctrl", "syscon"
> +    - compatible: "brcm,bcm<chip_id>-cpu-biu-ctrl",
> +		  "brcm,brcmstb-cpu-biu-ctrl",
> +		  "syscon"
>      - compatible: "brcm,bcm<chip_id>-hif-continuation", "syscon"
>  
> -hif-cpubiuctrl node
> +cpu-biu-ctrl node
>  -------------------
> -SoCs with Broadcom Brahma15 ARM-based CPUs have a specific Bus Interface Unit
> -(BIU) block which controls and interfaces the CPU complex to the different
> -Memory Controller Ports (MCP), one per memory controller (MEMC). This BIU block
> -offers a feature called Write Pairing which consists in collapsing two adjacent
> -cache lines into a single (bursted) write transaction towards the memory
> -controller (MEMC) to maximize write bandwidth.
> +SoCs with Broadcom Brahma15 ARM-based and Brahma53 ARM64-based CPUs have a
> +specific Bus Interface Unit (BIU) block which controls and interfaces the CPU
> +complex to the different Memory Controller Ports (MCP), one per memory
> +controller (MEMC). This BIU block offers a feature called Write Pairing which
> +consists in collapsing two adjacent cache lines into a single (bursted) write
> +transaction towards the memory controller (MEMC) to maximize write bandwidth.
>  
>  Required properties:
>  
> -    - compatible: must be "brcm,bcm7445-hif-cpubiuctrl", "syscon"
> +    - compatible: must be "brcm,bcm7445-cpu-biu-ctrl", "syscon"

Doesn't this need "brcm,brcmstb-cpu-biu-ctrl" too?

>  
>  Optional properties:
>  
> @@ -52,7 +54,7 @@ example:
>          };
>  
>          hif_cpubiuctrl: syscon@...400 {
> -            compatible = "brcm,bcm7445-hif-cpubiuctrl", "syscon";
> +            compatible = "brcm,bcm7445-cpu-biu-ctrl", "brcm,brcmstb-cpu-biu-ctrl", "syscon";
>              reg = <0x3e2400 0x5b4>;
>              brcm,write-pairing;
>          };
> -- 
> 2.9.3
>