linux-kernel - Re: [PATCH v5 04/12] perf util: Add rbtree node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171201182936.GC2482@two.firstfloor.org>
Date:   Fri, 1 Dec 2017 10:29:37 -0800
From:   Andi Kleen <andi@...stfloor.org>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>
Cc:     Andi Kleen <andi@...stfloor.org>,
        Jin Yao <yao.jin@...ux.intel.com>, jolsa@...nel.org,
        peterz@...radead.org, mingo@...hat.com,
        alexander.shishkin@...ux.intel.com, Linux-kernel@...r.kernel.org,
        ak@...ux.intel.com, kan.liang@...el.com, yao.jin@...el.com
Subject: Re: [PATCH v5 04/12] perf util: Add rbtree node_delete ops

On Fri, Dec 01, 2017 at 11:14:52AM -0300, Arnaldo Carvalho de Melo wrote:
> Em Fri, Dec 01, 2017 at 06:57:28PM +0800, Jin Yao escreveu:
> > @@ -130,7 +140,7 @@ void perf_stat__init_shadow_stats(void)
> >  	rblist__init(&runtime_saved_values);
> >  	runtime_saved_values.node_cmp = saved_value_cmp;
> >  	runtime_saved_values.node_new = saved_value_new;
> > -	/* No delete for now */
> > +	runtime_saved_values.node_delete = saved_value_delete;
> >  }
> 
> Andi, was some reason behind that comment, is it safe to add it now?

It is safe to add.