linux-kernel - Re: [PATCH v5 2/3] platform/chrome: cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2017 11:54:11 -0800
From:   Gwendal Grignou <gwendal@...omium.org>
To:     Thierry Escande <thierry.escande@...labora.com>
Cc:     Benson Leung <bleung@...omium.org>,
        Lee Jones <lee.jones@...aro.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Gwendal Grignou <gwendal@...omium.org>,
        Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v5 2/3] platform/chrome: cros_ec_lpc: Add support for
 Google Glimmer

This is not required.
Looking with dmidecode, Glimmer reports:
...
BIOS Information
        Vendor: coreboot
        Version: Google_Glimmer.5216.198.19
...

Therefore, the first entry of cros_ec_lpc_dmi_table will match.

Gwendal.

On Fri, Dec 1, 2017 at 5:42 AM, Thierry Escande
<thierry.escande@...labora.com> wrote:
> This patch adds device information to the DMI table of the cros_ec_lpc
> driver for Google Glimmer devices. Since Google BIOS does not enumerate
> devices in the LPC bus, the cros_ec_lpc driver checks for system
> compatibility and registers the cros_ec device itself.
>
> Signed-off-by: Thierry Escande <thierry.escande@...labora.com>
> ---
>  drivers/platform/chrome/cros_ec_lpc.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_lpc.c b/drivers/platform/chrome/cros_ec_lpc.c
> index 0b26a09..4a2fc55 100644
> --- a/drivers/platform/chrome/cros_ec_lpc.c
> +++ b/drivers/platform/chrome/cros_ec_lpc.c
> @@ -365,6 +365,13 @@ static const struct dmi_system_id cros_ec_lpc_dmi_table[] __initconst = {
>                         DMI_MATCH(DMI_PRODUCT_NAME, "Peppy"),
>                 },
>         },
> +       {
> +               /* x86-glimmer, the Lenovo Thinkpad Yoga 11e. */
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "GOOGLE"),
> +                       DMI_MATCH(DMI_PRODUCT_NAME, "Glimmer"),
> +               },
> +       },
>         { /* sentinel */ }
>  };
>  MODULE_DEVICE_TABLE(dmi, cros_ec_lpc_dmi_table);
> --
> 2.7.4
>