linux-kernel - RE: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in iwpm_send

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13AA599688F47243B14FCFCCC2C803BB3C65ABA3@fmsmsx104.amr.corp.intel.com>
Date:   Fri, 1 Dec 2017 19:58:39 +0000
From:   "Nikolova, Tatyana E" <tatyana.e.nikolova@...el.com>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Roland Dreier <roland@...estorage.com>,
        Jason Gunthorpe <jgg@...pe.ca>,
        Doug Ledford <dledford@...hat.com>
CC:     Arnd Bergmann <arnd@...db.de>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in
 iwpm_send_mapinfo()


> -----Original Message-----
> From: Geert Uytterhoeven [mailto:geert@...ux-m68k.org]
> Sent: Wednesday, November 29, 2017 2:48 AM
> To: Nikolova, Tatyana E <tatyana.e.nikolova@...el.com>; Roland Dreier
> <roland@...estorage.com>; Jason Gunthorpe <jgg@...pe.ca>; Doug
> Ledford <dledford@...hat.com>
> Cc: Arnd Bergmann <arnd@...db.de>; linux-rdma@...r.kernel.org; linux-
> kernel@...r.kernel.org; Geert Uytterhoeven <geert@...ux-m68k.org>
> Subject: [PATCH v2] RDMA/iwpm: Fix uninitialized error code in
> iwpm_send_mapinfo()
> 
> With gcc-4.1.2:
> 
>     drivers/infiniband/core/iwpm_util.c: In function ‘iwpm_send_mapinfo’:
>     drivers/infiniband/core/iwpm_util.c:647: warning: ‘ret’ may be used
> uninitialized in this function
> 
> Indeed, if nl_client is not found in any of the scanned has buckets, ret will be
> used uninitialized.
> 
> Preinitialize ret to -EINVAL to fix this.
> 
> Fixes: 30dc5e63d6a5ad24 ("RDMA/core: Add support for iWARP Port Mapper
> user space service")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> v2:
>   - Use -EINVAL instead of zero,
>   - Move the preinitialization to just before the loop, to catach future
>     early offenders,
>   - Drop RFC state.
> ---
>  drivers/infiniband/core/iwpm_util.c | 1 +
>  1 file changed, 1 insertion(+)
> 

Thanks.
Reviewed-by: Tatyana Nikolova <tatyana.e.nikolova@...el.com>

> diff --git a/drivers/infiniband/core/iwpm_util.c
> b/drivers/infiniband/core/iwpm_util.c
> index 3c4faadb8cddd7fd..81528f64061a49df 100644
> --- a/drivers/infiniband/core/iwpm_util.c
> +++ b/drivers/infiniband/core/iwpm_util.c
> @@ -654,6 +654,7 @@ int iwpm_send_mapinfo(u8 nl_client, int iwpm_pid)
>  	}
>  	skb_num++;
>  	spin_lock_irqsave(&iwpm_mapinfo_lock, flags);
> +	ret = -EINVAL;
>  	for (i = 0; i < IWPM_MAPINFO_HASH_SIZE; i++) {
>  		hlist_for_each_entry(map_info, &iwpm_hash_bucket[i],
>  				     hlist_node) {
> --
> 2.7.4