linux-kernel - Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2

Open Source and information security mailing list archives

Message-ID: <CAOMZO5BX1K_WGiTosbph67=93aZR8Wjo+YKUHd16o8LvnD685Q@mail.gmail.com>
Date:   Fri, 1 Dec 2017 18:13:20 -0200
From:   Fabio Estevam <festevam@...il.com>
To:     tyler@...nsourcefoundries.com
Cc:     Shawn Guo <shawnguo@...nel.org>,
        Fabio Estevam <fabio.estevam@....com>,
        Sascha Hauer <kernel@...gutronix.de>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/8] ARM: dts: imx7d-cl-som: add nodes for usbh, and usbotg2

On Thu, Nov 30, 2017 at 6:14 PM,  <tyler@...nsourcefoundries.com> wrote:
> From: Tyler Baker <tyler@...nsourcefoundries.com>
>
> Add device tree nodes for the USB hub, and USB OTG. i2c2 on this
> platform supports low state retention power state so lets use it.
>
> Signed-off-by: Tyler Baker <tyler@...nsourcefoundries.com>
> ---
>  arch/arm/boot/dts/imx7d-cl-som-imx7.dts | 36 +++++++++++++++++++++++++--------
>  1 file changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> index ae45af1..a9f690b 100644
> --- a/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> +++ b/arch/arm/boot/dts/imx7d-cl-som-imx7.dts
> @@ -30,6 +30,16 @@
>                 gpio = <&gpio1 5 GPIO_ACTIVE_HIGH>;
>                 enable-active-high;
>         };
> +
> +       reg_usbh_nreset: regulator@4 {

You should not use @4. Please make sure that regulators are not used
inside simple-bus.

> -
>         pinctrl_uart1: uart1grp {
>                 fsl,pins = <
>                         MX7D_PAD_UART1_TX_DATA__UART1_DCE_TX    0x79
> @@ -284,4 +297,11 @@
>                         MX7D_PAD_LPSR_GPIO1_IO05__GPIO1_IO5     0x14 /* OTG PWREN */
>                 >;
>         };
> -};
> \ No newline at end of file

This text here looks strange :-)

> +
> +       pinctrl_i2c2: i2c2grp {
> +               fsl,pins = <
> +                       MX7D_PAD_LPSR_GPIO1_IO07__I2C2_SDA              0x4000000f
> +                       MX7D_PAD_LPSR_GPIO1_IO06__I2C2_SCL              0x4000000f
> +               >;
> +       };
> +};
> --
> 2.9.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives