linux-kernel - Re: [PATCH] Kconfig: Make STRICT_DEVMEM default-y on x86 and arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <653e978c-5930-723d-001d-019868af29fd@redhat.com>
Date:   Fri, 1 Dec 2017 12:46:36 -0800
From:   Laura Abbott <labbott@...hat.com>
To:     Kees Cook <keescook@...omium.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     linux-kernel@...r.kernel.org, kernel-hardening@...ts.openwall.com,
        Mark Rutland <mark.rutland@....com>,
        Will Deacon <will.deacon@....com>, x86@...nel.org
Subject: Re: [PATCH] Kconfig: Make STRICT_DEVMEM default-y on x86 and arm64

On 12/01/2017 12:10 PM, Kees Cook wrote:
> Distros have been shipping with CONFIG_STRICT_DEVMEM=y for years now. It
> is probably time to flip this default for x86 and arm64.
> 

With my Fedora hat on,

Acked-by: Laura Abbott <labbott@...hat.com

> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
>   lib/Kconfig.debug | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 947d3e2ed5c2..39b123d04a36 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1985,7 +1985,7 @@ config STRICT_DEVMEM
>   	bool "Filter access to /dev/mem"
>   	depends on MMU && DEVMEM
>   	depends on ARCH_HAS_DEVMEM_IS_ALLOWED
> -	default y if TILE || PPC
> +	default y if TILE || PPC || X86 || ARM64
>   	---help---
>   	  If this option is disabled, you allow userspace (root) access to all
>   	  of memory, including kernel and userspace memory. Accidental
>