linux-kernel - Re: [PATCH v2] soc: qcom: smp2p: Access APCS as mailbox client

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Dec 2017 16:25:45 -0600
From:   Rob Herring <robh@...nel.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>,
        David Brown <david.brown@...aro.org>,
        Mark Rutland <mark.rutland@....com>,
        linux-arm-msm@...r.kernel.org, linux-soc@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Arun Kumar Neelakantam <aneela@...eaurora.org>
Subject: Re: [PATCH v2] soc: qcom: smp2p: Access APCS as mailbox client

On Wed, Nov 29, 2017 at 04:00:40PM -0800, Bjorn Andersson wrote:
> Attempt to acquire the APCS IPC through the mailbox framework and fall
> back to the old syscon based approach, to allow us to move away from
> using the syscon.
> 
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---
> 
> Changes since v1:
> - Added dt binding update
> - Specifies knows_txdone on the mailbox client
> 
>  .../devicetree/bindings/soc/qcom/qcom,smp2p.txt    |  8 ++++-
>  drivers/soc/qcom/Kconfig                           |  1 +
>  drivers/soc/qcom/smp2p.c                           | 39 ++++++++++++++++++----
>  3 files changed, 41 insertions(+), 7 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> index af9ca37221ce..a35af2dafdad 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,smp2p.txt
> @@ -17,9 +17,15 @@ processor ID) and a string identifier.
>  	Value type: <prop-encoded-array>
>  	Definition: one entry specifying the smp2p notification interrupt
>  
> -- qcom,ipc:
> +- mboxes:
>  	Usage: required
>  	Value type: <prop-encoded-array>
> +	Definition: reference to the associated doorbell in APCS, as described
> +		    in mailbox/mailbox.txt
> +
> +- qcom,ipc:
> +	Usage: required, unless mboxes is specified

Is this deprecated as mboxes is required, so it's never present?

> +	Value type: <prop-encoded-array>
>  	Definition: three entries specifying the outgoing ipc bit used for
>  		    signaling the remote end of the smp2p edge:
>  		    - phandle to a syscon node representing the apcs registers