lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 2 Dec 2017 13:11:30 +0100
From:   Linus Walleij <>
To:     Mika Westerberg <>
Cc:     Heikki Krogerus <>,
        Daniel Drake <>,
        Chris Chiu <>,
        Andy Shevchenko <>,,
        "" <>
Subject: Re: [PATCH v2] pinctrl: intel: Initialize GPIO properly when used
 through irqchip

On Wed, Nov 29, 2017 at 2:25 PM, Mika Westerberg
<> wrote:

> When a GPIO is requested using gpiod_get_* APIs the intel pinctrl driver
> switches the pin to GPIO mode and makes sure interrupts are routed to
> the GPIO hardware instead of IOAPIC. However, if the GPIO is used
> directly through irqchip, as is the case with many I2C-HID devices where
> I2C core automatically configures interrupt for the device, the pin is
> not initialized as GPIO. Instead we rely that the BIOS configures the
> pin accordingly which seems not to be the case at least in Asus X540NA
> SKU3 with Focaltech touchpad.
> When the pin is not properly configured it might result weird behaviour
> like interrupts suddenly stop firing completely and the touchpad stops
> responding to user input.
> Fix this by properly initializing the pin to GPIO mode also when it is
> used directly through irqchip.
> Fixes: 7981c0015af2 ("pinctrl: intel: Add Intel Sunrisepoint pin controller and GPIO support")
> Reported-by: Daniel Drake <>
> Reported-and-tested-by: Chris Chiu <>
> Signed-off-by: Mika Westerberg <>
> Cc:
> ---
> Changes from v1:
>   * Renamed __intel_gpio_init_gpio() to intel_gpio_set_gpio_mode()
>   * Added Fixes: and Cc
>   * Added Tested-by from Chris Chiu

Patch applied.

Linus Walleij

Powered by blists - more mailing lists