linux-kernel - Re: [PATCH] gpio: ftgpio010: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZCh-YrsEM+f2XbpYtPuTN_DtEFUFUb-DJjZ-0=EQ5FMA@mail.gmail.com>
Date:   Sat, 2 Dec 2017 16:30:08 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-gpio@...r.kernel.org
Subject: Re: [PATCH] gpio: ftgpio010: Fix platform_get_irq's error checking

Hi Arvind,

thanks for the patch!

On Thu, Nov 30, 2017 at 3:12 PM, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:

> The platform_get_irq() function returns negative if an error occurs.
> zero or positive number on success. platform_get_irq() error checking
> for zero is not correct.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
(...)
>         irq = platform_get_irq(pdev, 0);
> -       if (!irq)
> -               return -EINVAL;
> +       if (irq < 0)
> +               return irq;

This is wrong.
For an in-depth explanation why irq 0 in not valid, see:
https://lwn.net/Articles/470820/

It should be:

if (irq <= 0)
  return irq ? irq : -EINVAL;

Please update and resubmit. If you have more patches like this,
correct them too.

Yours,
Linus Walleij