lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sat, 2 Dec 2017 17:30:22 +0200
From:   Marcus Wolf <marcus.wolf@...f-entwicklungen.de>
To:     Marcin Ciupak <marcin.s.ciupak@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Marcus Wolf <linux@...f-Entwicklungen.de>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] staging: pi433: rf69.c style fix - code indent should
 use tabs

Revieved-by: Marcus Wolf <linux@...f-entwicklungen.de>

Am 11.10.2017 um 21:24 schrieb Marcin Ciupak:
> This patch fixes the following checkpatch.pl error:
> 
> ERROR: code indent should use tabs where possible
> 
> in rf69.c file as requested by TODO file.
> 
> Additionally some style warnings remain valid here and could be fixed by
> another patch.
> 
> Signed-off-by: Marcin Ciupak <marcin.s.ciupak@...il.com>
> ---
>   drivers/staging/pi433/rf69.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
> index 23d609474836..6420d1b67ccc 100644
> --- a/drivers/staging/pi433/rf69.c
> +++ b/drivers/staging/pi433/rf69.c
> @@ -959,8 +959,8 @@ int rf69_read_fifo (struct spi_device *spi, u8 *buffer, unsigned int size)
>   	/* prepare a bidirectional transfer */
>   	local_buffer[0] = REG_FIFO;
>   	memset(&transfer, 0, sizeof(transfer));
> -  	transfer.tx_buf = local_buffer;
> -  	transfer.rx_buf = local_buffer;
> +	transfer.tx_buf = local_buffer;
> +	transfer.rx_buf = local_buffer;
>   	transfer.len	= size+1;
>   
>   	retval = spi_sync_transfer(spi, &transfer, 1);
> 

-- 
Marcus Wolf

Wolf-Entwicklungen
Helene-Lange-Weg 23
80637 M√ľnchen

Powered by blists - more mailing lists