linux-kernel - Re: [PATCH] staging: pi433: Bugfix for shift operation in rf69_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171202145843.GB1242@kroah.com>
Date:   Sat, 2 Dec 2017 14:58:43 +0000
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Marcus Wolf <linux@...f-entwicklungen.de>
Cc:     dan.carpenter@...cle.com, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: Bugfix for shift operation in
 rf69_get_modulation()

On Sat, Dec 02, 2017 at 12:32:20PM +0200, Marcus Wolf wrote:
> Defines used in cases contain already shifted bits, so currentValue must not be shifted.

Please properly wrap your changelog text.

And you need a blank line before your signed-off-by line.

> signed_of_by: Marcus Wolf <linux@...f-entwicklungen.de>

"Signed-off-by:"

Did you run scripts/checkpatch.pl on your patch?

You sent 4 patches just now, which order should I apply them in?  I have
no idea, so please fix them up and resend them as a numbered patch
series so that I have a chance to get it right.

thanks,

greg k-h