linux-kernel - Re: IB: INFINIBAND should depend on HAS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171202000130.GB20454@ziepe.ca>
Date:   Fri, 1 Dec 2017 17:01:30 -0700
From:   Jason Gunthorpe <jgg@...pe.ca>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Yuval Shaia <yuval.shaia@...cle.com>,
        Doug Ledford <dledford@...hat.com>, linux-rdma@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: IB: INFINIBAND should depend on HAS_DMA

On Sun, Nov 19, 2017 at 07:58:30PM +0100, Geert Uytterhoeven wrote:
> If NO_DMA=y:
> 
>     ERROR: "bad_dma_ops" [net/sunrpc/xprtrdma/rpcrdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/smc/smc.ko] undefined!
>     ERROR: "bad_dma_ops" [net/rds/rds_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [net/9p/9pnet_rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/target/nvmet-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/nvme/host/nvme-rdma.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srpt/ib_srpt.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/srp/ib_srp.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/isert/ib_isert.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/iser/ib_iser.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/ulp/ipoib/ib_ipoib.ko] undefined!
>     ERROR: "bad_dma_ops" [drivers/infiniband/core/ib_core.ko] undefined!
> 
> Before, this was handled implicitly by the dependency on PCI.
> Add an explicit dependency on HAS_DMA to fix this.
> 
> Fixes: 931bc0d91639f8fb ("IB: Move PCI dependency from root KConfig to HW's KConfigs")
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
>  drivers/infiniband/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-rc, thanks

Jason