linux-kernel - Re: [PATCH net] rxrpc: Use correct netns source in rxrpc_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171203.100536.629501852369881483.davem@davemloft.net>
Date:   Sun, 03 Dec 2017 10:05:36 -0500 (EST)
From:   David Miller <davem@...emloft.net>
To:     dhowells@...hat.com
Cc:     netdev@...r.kernel.org, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] rxrpc: Use correct netns source in
 rxrpc_release_sock()

From: David Howells <dhowells@...hat.com>
Date: Fri, 01 Dec 2017 11:09:53 +0000

> In rxrpc_release_sock() there may be no rx->local value to access, so we
> can't unconditionally follow it to the rxrpc network namespace information
> to poke the connection reapers.
> 
> Instead, use the socket's namespace pointer to find the namespace.
> 
> This unfixed code causes the following static checker warning:
> 
> 	net/rxrpc/af_rxrpc.c:898 rxrpc_release_sock()
> 	error: we previously assumed 'rx->local' could be null (see line 887)
> 
> Fixes: 3d18cbb7fd0c ("rxrpc: Fix conn expiry timers")
> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: David Howells <dhowells@...hat.com>

Applied.