linux-kernel - Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add sdw_master

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171203171013.GP32417@localhost>
Date:   Sun, 3 Dec 2017 22:40:14 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>,
        Takashi <tiwai@...e.de>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [alsa-devel] [PATCH v4 12/15] soundwire: cdns: Add
 sdw_master_ops and IO transfer support

On Fri, Dec 01, 2017 at 06:02:24PM -0600, Pierre-Louis Bossart wrote:
> 
> >  struct sdw_cdns {
> >  	struct device *dev;
> >  	struct sdw_bus bus;
> >  	unsigned int instance;
> >+	u32 response_buf[0x80];
> 
> last nit-pick: use a #define for the size.

okay last one huh :) yeah will add.

> Also are you sure about the value? I vaguely recall that the FIFO was
> 32-deep, you are confusing bytes and words here?

I dont think this is related to FIFO depth, this is buffer to hold values.
Will check though..

-- 
~Vinod