linux-kernel - Re: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171203171255.GR32417@localhost>
Date:   Sun, 3 Dec 2017 22:42:56 +0530
From:   Vinod Koul <vinod.koul@...el.com>
To:     Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        ALSA <alsa-devel@...a-project.org>, Mark <broonie@...nel.org>,
        Takashi <tiwai@...e.de>, patches.audio@...el.com,
        alan@...ux.intel.com,
        Charles Keepax <ckeepax@...nsource.cirrus.com>,
        Sagar Dharia <sdharia@...eaurora.org>,
        srinivas.kandagatla@...aro.org, plai@...eaurora.org,
        Sudheer Papothi <spapothi@...eaurora.org>
Subject: Re: [alsa-devel] [PATCH v4 00/15] soundwire: Add a new SoundWire
 subsystem

On Fri, Dec 01, 2017 at 06:24:10PM -0600, Pierre-Louis Bossart wrote:
> On 12/1/17 3:56 AM, Vinod Koul wrote:
> >This patch series adds a new SoundWire subsystem which implements a
> >new MIPI bus protocol 'SoundWire'.
> 
> Sorry for the late feedback Vinod and team.
> 
> Overall the code looks very good to me and aligned with the MIPI specs,
> there are only a couple of points that were added (or some code not removed)
> during the code cleanups, e.g.
> - device12..14 should not be used
> - device_property handling (master/controller confusion?)
> - error cases on transfers
> - spec race condition on interrupt clear (not bad but to be discussed
> further)
> - some comments and code nit-picks
> 
> This is starting to get into second-order reviews really, which shows this
> is becoming quite mature. And for the record this work isn't just scratching
> the surface, it helped identify a couple of documentation issues in the MIPI
> specs which will lead to clarifications in future revisions.

Thanks for the good word, most the stuff you pointed needs a very detailed
review, so many thaks for spending time on this one.

> Looking forward to a v5 ;-)

Yeah should be there in next few days..

-- 
~Vinod