linux-kernel - Re: [PATCH 1/2] dt-bindings: trivial: add tfa9879 device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ec7ae30-eeac-3cf8-15ad-f6c3a110c5d7@axentia.se>
Date:   Sun, 3 Dec 2017 21:53:58 +0100
From:   Peter Rosin <peda@...ntia.se>
To:     Fabio Estevam <festevam@...il.com>
Cc:     linux-kernel <linux-kernel@...r.kernel.org>,
        Mark Rutland <mark.rutland@....com>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Russell King <linux@...linux.org.uk>,
        Rob Herring <robh+dt@...nel.org>,
        Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 1/2] dt-bindings: trivial: add tfa9879 device

On 2017-12-03 12:12, Fabio Estevam wrote:
> Hi Peter,
> 
> On Sun, Dec 3, 2017 at 4:59 AM, Peter Rosin <peda@...ntia.se> wrote:
> 
>> Right. However, the patch adding that should have been sent to me, the
>> maintainer of the driver. That is carefully recorded in MAINTAINERS. So,
>> forgive me for assuming that nothing had changed in the driver behind my
>> back.
>>
>> Had that patch been sent my way as it should have been, I would have
>> insisted that maintenance of the bindings had been kept together with
>> the maintenance of the driver.
> 
> When I sent this patch ./scripts/get_maintainer.pl did lot list your
> name, so that's why I did not put you on Cc, sorry.
> 
> 4.15-rc1 still does not list you, but linux-next does.

That's funny, because I get the below on both 4.14 and 4.15-rc1. And I
expect the same ever since the driver was added some 3 years ago.

$ scripts/get_maintainer.pl your-patch-from[1].diff | grep Peter
Peter Rosin <peda@...ntia.se> (maintainer:NXP TFA9879 DRIVER)

[1] https://patchwork.ozlabs.org/patch/815930/

By the way, scripts/checkpatch.pl on that patch reports
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?

> Would you like me to send the following patch so that new binding
> updates go to you?

Naahh, I'll claim it myself, that way I can clean up some nits in the
actual file while at it...

Cheers,
Peter

> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -9808,6 +9808,7 @@ NXP TFA9879 DRIVER
>  M:     Peter Rosin <peda@...ntia.se>
>  L:     alsa-devel@...a-project.org (moderated for non-subscribers)
>  S:     Maintained
> +F:     Documentation/devicetree/bindings/sound/tfa9879.txt
>  F:     sound/soc/codecs/tfa9879*
>