linux-kernel - Re: selftests: Testing a write attempt into a full file?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5A2473A5.2070601@bfs.de>
Date:   Sun, 03 Dec 2017 22:59:01 +0100
From:   walter harms <wharms@....de>
To:     unlisted-recipients:; (no To-header on input)
CC:     linux-kselftest@...r.kernel.org, Shuah Khan <shuah@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org
Subject: Re: selftests: Testing a write attempt into a full file?



Am 03.12.2017 21:46, schrieb SF Markus Elfring:
> Hello,
> 
> I have constructed another demonstration program.
> 
> 
> #include <errno.h>
> #include <stdio.h>
> #include <stdlib.h>
> 
> int main(void)
> {
> 	FILE *f = fopen("/dev/full", "a");
> 
> 	if (!f)
> 		goto report_failure;
> 
> 	{
> 	int const c = 'X';
> 
> 	if (fputc(c, f) != c)
> 		goto report_failure;
> 	}
> 
Your test is broken, you are writing actualy into a buffer.
Adding setbuf(f,NULL) to disable buffering will return
main: No space left on device

Otherwise force the buffer to be fflush()ed and i it will also
report an error.

> 	return EXIT_SUCCESS;
> 
> report_failure:
> 	perror(__func__);
from perror(3):
 errno is undefined after a successful library call

so this may or may not return what you expect.

re,
 wh
> 	return errno;
> }
> 
> 
> I got the following result.
> 
> elfring@...ne:~/Projekte/selftests> gcc-7 putc_into_full_file1.c && ./a.out; echo $?
> 0
> 
> 
> Does such a simple test example need further software development considerations?
> 
> Regards,
> Markus
> --
> To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>