linux-kernel - Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201712032003.VTa0HJzB%fengguang.wu@intel.com>
Date:   Sun, 3 Dec 2017 20:56:00 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Thiago Rafael Becker <thiago.becker@...il.com>
Cc:     kbuild-all@...org, bfields@...ldses.org, linux-nfs@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
        Thiago Rafael Becker <thiago.becker@...il.com>
Subject: Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of
 set_groups.

Hi Thiago,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v4.15-rc1 next-20171201]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Thiago-Rafael-Becker/kernel-Move-groups_sort-to-the-caller-of-set_groups/20171203-191757
config: x86_64-randconfig-x011-201749 (attached as .config)
compiler: gcc-7 (Debian 7.2.0-12) 7.2.1 20171025
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   kernel/uid16.c: In function 'SYSC_setgroups16':
>> kernel/uid16.c:195:2: error: implicit declaration of function 'groups_sort'; did you mean 'cgroup_fork'? [-Werror=implicit-function-declaration]
     groups_sort(group_info);
     ^~~~~~~~~~~
     cgroup_fork
   cc1: some warnings being treated as errors

vim +195 kernel/uid16.c

   175	
   176	SYSCALL_DEFINE2(setgroups16, int, gidsetsize, old_gid_t __user *, grouplist)
   177	{
   178		struct group_info *group_info;
   179		int retval;
   180	
   181		if (!may_setgroups())
   182			return -EPERM;
   183		if ((unsigned)gidsetsize > NGROUPS_MAX)
   184			return -EINVAL;
   185	
   186		group_info = groups_alloc(gidsetsize);
   187		if (!group_info)
   188			return -ENOMEM;
   189		retval = groups16_from_user(group_info, grouplist);
   190		if (retval) {
   191			put_group_info(group_info);
   192			return retval;
   193		}
   194	
 > 195		groups_sort(group_info);
   196		retval = set_current_groups(group_info);
   197		put_group_info(group_info);
   198	
   199		return retval;
   200	}
   201	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (24716 bytes)