lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Dec 2017 13:58:19 +0000 From: Gilad Ben-Yossef <gilad@...yossef.com> To: Greg Kroah-Hartman <gregkh@...uxfoundation.org> Cc: Ofir Drang <ofir.drang@....com>, stable@...r.kernel.org, linux-kernel@...r.kernel.org, linux-crypto@...r.kernel.org, driverdev-devel@...uxdriverproject.org, devel@...verdev.osuosl.org Subject: [PATCH 08/10] staging: ccree: NULLify backup_info when unused backup_info field is only allocated for decrypt code path. The field was not nullified when not used causing a kfree in an error handling path to attempt to free random addresses as uncovered in stress testing. Fixes: 737aed947f9b ("staging: ccree: save ciphertext for CTS IV") Cc: stable@...r.kernel.org Signed-off-by: Gilad Ben-Yossef <gilad@...yossef.com> --- drivers/staging/ccree/ssi_cipher.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c index 9019615..7b484f1 100644 --- a/drivers/staging/ccree/ssi_cipher.c +++ b/drivers/staging/ccree/ssi_cipher.c @@ -907,6 +907,7 @@ static int ssi_ablkcipher_encrypt(struct ablkcipher_request *req) unsigned int ivsize = crypto_ablkcipher_ivsize(ablk_tfm); req_ctx->is_giv = false; + req_ctx->backup_info = NULL; return ssi_blkcipher_process(tfm, req_ctx, req->dst, req->src, req->nbytes, req->info, ivsize, -- 2.7.4
Powered by blists - more mailing lists