linux-kernel - Re: [PATCH v3 1/4] uinput: Add ioctl for using monotonic/ boot times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CABeXuvpoAp7PPj=r5VuKXMk5vYUngm0yJBTNCvzmHv1kTJ+Prg@mail.gmail.com>
Date:   Mon, 4 Dec 2017 12:36:21 -0800
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        "open list:HID CORE LAYER" <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Peter Hutterer <peter.hutterer@...-t.net>
Subject: Re: [PATCH v3 1/4] uinput: Add ioctl for using monotonic/ boot times

On Mon, Dec 4, 2017 at 6:21 AM, Arnd Bergmann <arnd@...db.de> wrote:
> On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
>> struct timeval which is part of struct input_event to
>> maintain the event times is not y2038 safe.
>>
>> Real time timestamps are also not ideal for input_event
>> as this time can go backwards as noted in the patch
>> a80b83b7b8 by John Stultz.
>>
>> Arnd Bergmann suggested deprecating real time and using
>> monotonic or other timers for all input_event times as a
>> solution to both the above problems.
>>
>> Add a new ioctl to let the user dictate the kind of time
>> to be used for input events. This is similar to the evdev
>> implementation of the feature. Realtime is still the
>> default time. This is to maintain backward compatibility.
>>
>> The structure to maintain input events will be changed
>> in a different patch.
>
> Based on Peter's comment from when you first posted this,
> https://patchwork.kernel.org/patch/9381209/, I tried to follow
> the code path again, to see if we can come up with a way
> to avoid introducing a new ioctl.
>
> There is one idea I had now: The two events we
> get (upload and erase) are both triggered from evdev,
> which gets called from user space through the EVIOCSFF
> and EVIOCRMFF ioctls. This device already sets the
> clock domain. Would it make sense to send the event
> to the uinput owner using the same clock domain that
> was set by the evdev owner, or are these two separate
> by definition?

uinput and evdev are two separate drivers. One is to write events to a
virtual device and the other is to read from any input device.
I considered both of these separate as the two events.
Let me know if you guys prefer something else.

We could also do away with this patch and just say we extend time till
2106 as we change struct input_event if we are okay with using
realtime only for uinput.

-Deepa