[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <x49indmw50k.fsf@segfault.boston.devel.redhat.com>
Date: Mon, 04 Dec 2017 16:35:23 -0500
From: Jeff Moyer <jmoyer@...hat.com>
To: Kirill Tkhai <ktkhai@...tuozzo.com>
Cc: Benjamin LaHaise <ben@...munityfibre.ca>, axboe@...nel.dk,
viro@...iv.linux.org.uk, tj@...nel.org,
linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-aio@...ck.org, oleg@...hat.com
Subject: Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup
Kirill Tkhai <ktkhai@...tuozzo.com> writes:
> Hi, Benjamin,
>
> On 04.12.2017 19:52, Benjamin LaHaise wrote:
>> Hi Kirill,
>>
>> On Mon, Dec 04, 2017 at 07:12:51PM +0300, Kirill Tkhai wrote:
>>> Hi,
>>>
>>> this patch set introduces accounting aio_nr and aio_max_nr per blkio cgroup.
>>> It may be used to limit number of aio requests, which are available for
>>> a cgroup, and could be useful for containers.
>>>
>>> The accounting is hierarchical, and aio contexts, allocated in child cgroup,
>>> are accounted in parent cgroups too.
>>>
>>> Also, new cgroup file "io.aio_nr" is introduced. It's used to set cgroup
>>> aio requests limit, to show current limit and number of currenly occupied
>>> requests.
>>
>> Where are your test cases to check this functionality in the libaio test
>> suite?
>
> I tried to find actual libaio test suite repository url in google,
> but there is no certain answer. Also, there is no information in kernel
> anywhere (I hope I grepped right).
>
> Could you please provide url where actual upstream libaio could be obtained?
https://pagure.io/libaio
Patches can be sent to this list (linux-aio).
Cheers,
Jeff
>>> Patches 1-3 are refactoring.
>>> Patch 4 is the place where the accounting actually introduced.
>>> Patch 5 adds "io.aio_nr" file.
>>>
>>> ---
>>>
>>> Kirill Tkhai (5):
>>> aio: Move aio_nr increment to separate function
>>> aio: Export aio_nr_lock and aio_max_nr initial value to include/linux/aio.h
>>> blkcg: Add blkcg::blkg_aio_nr and blkcg::blkg_aio_max_nr
>>> blkcg: Charge aio requests in blkio cgroup hierarchy
>>> blkcg: Add cgroup file to configure blkcg::blkg_aio_max_nr
>>>
>>>
>>> block/blk-cgroup.c | 88 +++++++++++++++++++++++++-
>>> fs/aio.c | 151 ++++++++++++++++++++++++++++++++++++++++----
>>> include/linux/aio.h | 21 ++++++
>>> include/linux/blk-cgroup.h | 4 +
>>> 4 files changed, 247 insertions(+), 17 deletions(-)
>>>
>>> --
>>> Signed-off-by: Kirill Tkhai <ktkhai@...tuozzo.com>
>>>
>>
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-aio' in
> the body to majordomo@...ck.org. For more info on Linux AIO,
> see: http://www.kvack.org/aio/
> Don't email: <a href=mailto:"aart@...ck.org">aart@...ck.org</a>
Powered by blists - more mailing lists