linux-kernel - Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mqdindmoqga.fsf@linux-x5ow.site>
Date:   Mon, 04 Dec 2017 09:19:33 +0100
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Jens Axboe <axboe@...com>, linux-block@...r.kernel.org,
        Christoph Hellwig <hch@...radead.org>,
        linux-scsi@...r.kernel.org,
        "Martin K . Petersen" <martin.petersen@...cle.com>,
        "James E . J . Bottomley" <jejb@...ux.vnet.ibm.com>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        linux-kernel@...r.kernel.org, Hannes Reinecke <hare@...e.com>
Subject: Re: [PATCH] SCSI: delay run queue if device is blocked in scsi_dev_queue_ready()


Hi Ming,

Ming Lei <ming.lei@...hat.com> writes:
> This issue can be triggered by the following script:
>
> 	#!/bin/sh
> 	rmmod scsi_debug
> 	modprobe scsi_debug max_queue=1
>
> 	DEVICE=`ls -d /sys/bus/pseudo/drivers/scsi_debug/adapter*/host*/target*/*/block/* | head -1 | xargs basename`
>
> 	DISK_DIR=`ls -d /sys/block/$DEVICE/device/scsi_disk/*`
>
> 	echo "using scsi device $DEVICE"
> 	echo "-1" >/sys/bus/pseudo/drivers/scsi_debug/every_nth
> 	echo starting loop $i
> 	echo "temporary write through" >$DISK_DIR/cache_type
> 	echo "128" >/sys/bus/pseudo/drivers/scsi_debug/opts
> 	echo none > /sys/block/$DEVICE/queue/scheduler
> 	dd if=/dev/$DEVICE of=/dev/null bs=1M iflag=direct count=1 &
> 	sleep 5
> 	echo "0" >/sys/bus/pseudo/drivers/scsi_debug/opts
> 	wait
> 	echo "SUCCESS"

Can you please submit a test-case for blktest as well, given you have a
nice reproducer?

Thanks,
        Johannes
-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850