linux-kernel - Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support Spreadtrum SC2731 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 4 Dec 2017 17:03:14 +0800
From:   Erick Chen <erick.chen@...eadtrum.com>
To:     Mark Brown <broonie@...nel.org>
CC:     <robh+dt@...nel.org>, <mark.rutland@....com>,
        <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <baolin.wang@...aro.org>,
        <baolin.wang@...eadtrum.com>
Subject: Re: [PATCH 2/2] regulator: sc2731: Add regulator driver to support
 Spreadtrum SC2731 PMIC

Hi Mark,

On Fri, Dec 01, 2017 at 01:01:37PM +0000, Mark Brown wrote:
> On Fri, Dec 01, 2017 at 04:58:16PM +0800, Erick Chen wrote:
> 
> > +static const struct of_device_id sc2731_regulator_of_match[] = {
> > +	{.compatible = "sprd,sc2731-regulator",},
> > +	{}
> > +};
> > +MODULE_DEVICE_TABLE(of, sc2731_regulator_of_match);
> 
> This looks like a subdriver for one specific device that can't be reused
> with anything else as it's specific to an individual device so I'd not
> expect it to appear as a separate thing in DT - the way Linux splits
> things up might not map well onto other OSs and may even change in
> future versions of Linux (look at all the audio drivers with clock
> controllers in them for example).  I'd expect the MFD to just register
> the subdevice without needing it to appear in the DT.
>

Make sense, i will remove the of_device_id table in next version.
 
> > +subsys_initcall(sc2731_regulator_init);
> > +module_exit(sc2731_regulator_exit);
> 
> Why not module_platform_driver()?  Deferred probe should sort out probe
> order.

On some Spreadtrum old platforms, we need to power on the CPU cores ASAP.
But now this issue had been fixed after some investigation, so we can change
subsys_initcall() to module_init() level as you suggested.

Very appreciated for your helpful comments.