linux-kernel - Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <13507001.EQOuo8KY2k@avalon>
Date:   Mon, 04 Dec 2017 15:22:07 +0200
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Brian Norris <briannorris@...omium.org>
Cc:     heiko@...ech.de, Archit Taneja <architt@...eaurora.org>,
        Andrzej Hajda <a.hajda@...sung.com>,
        David Airlie <airlied@...ux.ie>,
        Yannick Fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent Abriou <vincent.abriou@...com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Sean Paul <seanpaul@...omium.org>,
        Nickey Yang <nickey.yang@...k-chips.com>, hl@...k-chips.com,
        linux-rockchip@...ts.infradead.org, mka@...omium.org,
        Doug Anderson <dianders@...omium.org>, robh+dt@...nel.org,
        mark.rutland@....com, hoegsberg@...il.com, zyw@...k-chips.com,
        xbl@...k-chips.com
Subject: Re: [PATCH v4] arm64: dts: rockchip: update mipi cells for RK3399

Hi Nickey,

Thank you for the patch.

On Wednesday, 29 November 2017 20:47:55 EET Brian Norris wrote:
> From: Nickey Yang <nickey.yang@...k-chips.com>
> 
> We might include additional ports in derivative device trees, so the
> 'port' node should have an address, and the parent 'ports' node needs
> /#{addres,size}-cells.
> 
> v4:
>  * keep #{address,size}-cells in both 'ports' and 'port@0' nodes
>  * separate from the rest of the series, since this is mostly
>    independent of the driver refactoring
> 
> Signed-off-by: Nickey Yang <nickey.yang@...k-chips.com>
> Signed-off-by: Brian Norris <briannorris@...omium.org>

Reviewed-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>

> ---
>  arch/arm64/boot/dts/rockchip/rk3399.dtsi | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index d340b58ab184..c6dae25a3f23
> 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -1652,7 +1652,11 @@
>  		status = "disabled";
> 
>  		ports {
> -			mipi_in: port {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			mipi_in: port@0 {
> +				reg = <0>;
>  				#address-cells = <1>;
>  				#size-cells = <0>;


-- 
Regards,

Laurent Pinchart