linux-kernel - Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANk1AXRZV3cRYHoFONUdMj6mbM+6aV3h5JvbMhZR7WhSLXTWFw@mail.gmail.com>
Date:   Mon, 4 Dec 2017 09:44:50 -0600
From:   Alan Tull <atull@...nel.org>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     Alexey Khoroshilov <khoroshilov@...ras.ru>,
        linux-fpga@...r.kernel.org,
        linux-kernel <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH] fpga: socfpga-a10: disable clk on error in socfpga_a10_fpga_probe()

On Fri, Dec 1, 2017 at 7:21 PM, Moritz Fischer <mdf@...nel.org> wrote:

Hi Alexey,

Thanks for the fix!

Alan

> Hi Alexey,
>
> On Fri, Dec 01, 2017 at 11:26:24PM +0300, Alexey Khoroshilov wrote:
>> If fpga_mgr_register() fails, a clock is left undisabled.
>>
>> Found by Linux Driver Verification project (linuxtesting.org).
>>
>> Signed-off-by: Alexey Khoroshilov <khoroshilov@...ras.ru>
> Reviewed-by: Moritz Fischer <mdf@...nel.org>

Acked-by: Alan Tull <atull@...nel.org>

>> ---
>>  drivers/fpga/socfpga-a10.c | 8 +++++++-
>>  1 file changed, 7 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/fpga/socfpga-a10.c b/drivers/fpga/socfpga-a10.c
>> index f8770af0f6b5..a46e343a5b72 100644
>> --- a/drivers/fpga/socfpga-a10.c
>> +++ b/drivers/fpga/socfpga-a10.c
>> @@ -519,8 +519,14 @@ static int socfpga_a10_fpga_probe(struct platform_device *pdev)
>>               return -EBUSY;
>>       }
>>
>> -     return fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager",
>> +     ret = fpga_mgr_register(dev, "SoCFPGA Arria10 FPGA Manager",
>>                                &socfpga_a10_fpga_mgr_ops, priv);
>> +     if (ret) {
>> +             clk_disable_unprepare(priv->clk);
>> +             return ret;
>> +     }
>> +
>> +     return 0;
>>  }
>>
>>  static int socfpga_a10_fpga_remove(struct platform_device *pdev)
>> --
>> 2.7.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>
> Thanks for your patch,
>
> Moritz