linux-kernel - Re: [PATCH] riscv/ftrace: Add basic support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171204030946.GB30057@d0b76efcf64c>
Date:   Mon, 4 Dec 2017 11:09:47 +0800
From:   Alan Kao <nonerkao@...il.com>
To:     Philippe Ombredanne <pombredanne@...b.com>
Cc:     Palmer Dabbelt <palmer@...ive.com>, Albert Ou <albert@...ive.com>,
        Steven Rostedt <rostedt@...dmis.org>, patches@...ups.riscv.org,
        Ingo Molnar <mingo@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Alan Kao <alankao@...estech.com>,
        Greentime Hu <greentime@...estech.com>
Subject: Re: [PATCH] riscv/ftrace: Add basic support

On Thu, Nov 30, 2017 at 12:31:53PM +0100, Philippe Ombredanne wrote:
> On Thu, Nov 30, 2017 at 9:53 AM, Alan Kao <nonerkao@...il.com> wrote:
> []
> > diff --git a/arch/riscv/include/asm/ftrace.h b/arch/riscv/include/asm/ftrace.h
> > new file mode 100644
> > index 000000000000..38beadb07ad5
> > --- /dev/null
> > +++ b/arch/riscv/include/asm/ftrace.h
> > @@ -0,0 +1,23 @@
> > +/*
> > + * Copyright (C) 2017 Andes Technology Corporation
> > + *
> > + * This program is free software; you can redistribute it and/or modify
> > + * it under the terms of the GNU General Public License version 2 as
> > + * published by the Free Software Foundation.
> > + *
> > + * This program is distributed in the hope that it will be useful,
> > + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > + * GNU General Public License for more details.
> > + *
> > + * You should have received a copy of the GNU General Public License
> > + * along with this program.  If not, see <http://www.gnu.org/licenses/>.
> > + */
> 
> You may want to use the new SPDX ids here instead?
> e.g.
> > +// SPDX-License-Identifer: GPL-2.0
> > +// Copyright (C) 2017 Andes Technology Corporation
> 
> Neater and simpler?
> See Linus posts on the topic of comment styles too BTW

Thanks for the tips.
I'll fix this in the next version.

Alan Kao

> 
> -- 
> Cordially
> Philippe Ombredanne