linux-kernel - Re: [PATCH] scripts/faddr2line: extend usage on generic arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFLxGvzBan+1-3z2bPr34GrtodnJrG=P-BHHQHpAkurSDnGOoQ@mail.gmail.com>
Date:   Tue, 5 Dec 2017 22:30:49 +0100
From:   Richard Weinberger <richard.weinberger@...il.com>
To:     "Liu, Changcheng" <changcheng.liu@...el.com>
Cc:     kstewart@...uxfoundation.org, Neil Brown <neilb@...e.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg KH <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] scripts/faddr2line: extend usage on generic arch

On Tue, Nov 21, 2017 at 10:29 AM, Liu, Changcheng
<changcheng.liu@...el.com> wrote:
> fadd2line script should use the binary tool
> used for the target system.
>
> Signed-off-by: Liu Changcheng <changcheng.liu@...el.com>
>
> diff --git a/scripts/faddr2line b/scripts/faddr2line
> index 1f5ce95..39e07d8 100755
> --- a/scripts/faddr2line
> +++ b/scripts/faddr2line
> @@ -44,9 +44,16 @@
>  set -o errexit
>  set -o nounset
>
> +READELF="${CROSS_COMPILE}readelf"
> +ADDR2LINE="${CROSS_COMPILE}addr2line"
> +SIZE="${CROSS_COMPILE}size"
> +NM="${CROSS_COMPILE}nm"

How is this supposed to work when not cross compiling?
When CROSS_COMPILE is not set this script will terminate because of
the "set -o nounset" bash setting...

-- 
Thanks,
//richard