lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Dec 2017 14:48:46 -0700 From: Logan Gunthorpe <logang@...tatee.com> To: Serge Semin <fancer.lancer@...il.com>, Jon Mason <jdmason@...zu.us> Cc: Dave Jiang <dave.jiang@...el.com>, "Hubbe, Allen" <Allen.Hubbe@....com>, "S-k, Shyam-sundar" <Shyam-sundar.S-k@....com>, "Yu, Xiangliang" <Xiangliang.Yu@....com>, Gary R Hook <gary.hook@....com>, Sergey.Semin@...latforms.ru, linux-ntb <linux-ntb@...glegroups.com>, linux-kernel <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 01/15] NTB: Rename NTB messaging API methods On 05/12/17 01:54 PM, Serge Semin wrote: >> Just because no one said anything before, doesn't mean it's >> acceptable. I think that is the official Linux code review mantra ;-) >> >> Okay, if we are going to do it this way, then return ~0 instead. At >> least that way there is no ugly cast. >> > > Ok. I'll replace it with ~(u32)0. That's exactly the same just more confusing. I'm still in favor of leaving it the way it was. Logan
Powered by blists - more mailing lists