linux-kernel - Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wp20stm0.fsf@notabene.neil.brown.name>
Date:   Wed, 06 Dec 2017 09:22:15 +1100
From:   NeilBrown <neilb@...e.com>
To:     Ben Hutchings <ben.hutchings@...ethink.co.uk>
Cc:     stable@...r.kernel.org, Ian Kent <raven@...maw.net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4.4 20/96] autofs: dont fail mount for transient error

On Tue, Dec 05 2017, Ben Hutchings wrote:

> On Tue, 2017-11-28 at 11:22 +0100, Greg Kroah-Hartman wrote:
>> 4.4-stable review patch.  If anyone has any objections, please let me know.
>> 
>> ------------------
>> 
>> From: NeilBrown <neilb@...e.com>
>> 
>> commit ecc0c469f27765ed1e2b967be0aa17cee1a60b76 upstream.
> [...]
>> @@ -173,7 +175,18 @@ static void autofs4_notify_daemon(struct
>>  	mutex_unlock(&sbi->wq_mutex);
>>  
>>  	if (autofs4_write(sbi, pipe, &pkt, pktsz))
>> +	switch (ret = autofs4_write(sbi, pipe, &pkt, pktsz)) {
>
> I'm pretty sure the if-statement was meant to be replaced by the
> switch-statement here.  (This is wrong upstream, not an error in
> backporting.)

Argg yes.  Thanks for the review!!!
Fix posted.

Thanks,
NeilBrown

>
> Ben.
>
>> +	case 0:
>> +		break;
>> +	case -ENOMEM:
>> +	case -ERESTARTSYS:
>> +		/* Just fail this one */
>> +		autofs4_wait_release(sbi, wq->wait_queue_token, ret);
>> +		break;
>> +	default:
>>  		autofs4_catatonic_mode(sbi);
>> +		break;
>> +	}
>>  	fput(pipe);
>>  }
>>  
>
> -- 
> Ben Hutchings
> Software Developer, Codethink Ltd.

Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)