linux-kernel - Re: [PATCH v2 02/22] mmc: renesas_sdhi: remove wrong depends on to enable compile test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Dec 2017 13:16:37 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Wolfram Sang <wsa@...-dreams.de>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        linux-renesas-soc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 02/22] mmc: renesas_sdhi: remove wrong depends on to
 enable compile test

2017-12-05 0:25 GMT+09:00 Wolfram Sang <wsa@...-dreams.de>:
> On Sat, Nov 25, 2017 at 01:24:37AM +0900, Masahiro Yamada wrote:
>> ARCH_RENESAS is a stronger condition than (ARM || ARM64).
>> If ARCH_RENESAS is enabled, (ARM || ARM64) is met as well.
>>
>> What is worse, the first depends on line prevents COMPILE_TEST from
>> enabling this driver.  It should be removed.
>>
>> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
>> Acked-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
>
> Because COMPILE_TEST now works, buildbot spotted something:
>
> https://www.spinics.net/lists/linux-i2c/msg32556.html
>
> Likely, we should include linux/io.h in the header?
>

Yes.  Can you insert a patch before this one?


-- 
Best Regards
Masahiro Yamada