linux-kernel - [PATCH] kernel/stop_machine: fix (de)reference function pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20171205050246.GA81448@sofia>
Date:   Tue, 5 Dec 2017 13:02:46 +0800
From:   "Liu, Changcheng" <changcheng.liu@...el.com>
To:     paulmck@...ux.vnet.ibm.com, mingo@...nel.org, tglx@...utronix.de,
        bigeasy@...utronix.de
Cc:     linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
        changcheng.liu@...el.com
Subject: [PATCH] kernel/stop_machine: fix (de)reference function pointer

It's better to avoid ambiguity when (de)referencing function
pointer.

Signed-off-by: Liu Changcheng <changcheng.liu@...el.com>

diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
index b759126..121d6aa 100644
--- a/kernel/stop_machine.c
+++ b/kernel/stop_machine.c
@@ -577,7 +577,7 @@ int stop_machine_cpuslocked(cpu_stop_fn_t fn, void *data,
 
 		local_irq_save(flags);
 		hard_irq_disable();
-		ret = (*fn)(data);
+		ret = fn(data);
 		local_irq_restore(flags);
 
 		return ret;
-- 
2.7.4