lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 5 Dec 2017 09:58:54 +0900 From: Masahiro Yamada <yamada.masahiro@...ionext.com> To: Mark Brown <broonie@...nel.org> Cc: Katsuhiro Suzuki <suzuki.katsuhiro@...ionext.com>, alsa-devel@...a-project.org, Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org, Masami Hiramatsu <masami.hiramatsu@...aro.org>, Jassi Brar <jaswinder.singh@...aro.org>, linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Thomas Gleixner <tglx@...utronix.de>, Greg Kroah-Hartman <gregkh@...uxfoundation.org> Subject: Re: [PATCH 4/8] ASoC: uniphier: add support for UniPhier EVEA codec +CC Greg-KH +CC Thomas Gleixner 2017-12-05 3:20 GMT+09:00 Mark Brown <broonie@...nel.org>: > On Wed, Nov 22, 2017 at 08:43:17PM +0900, Katsuhiro Suzuki wrote: > >> +++ b/sound/soc/uniphier/evea.c >> @@ -0,0 +1,567 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Socionext UniPhier EVEA ADC/DAC codec driver. >> + * >> + * Copyright (c) 2016-2017 Socionext Inc. > > Make the entire comment a C++ comment, don't mix and match like this - > it's ugly. Otherwise this looks good so I'll apply it, please send a > followup patch fixing this (and I guess the same thing will apply to > other files). Indeed ugly, but I think this is intentional to make the SPDX line stand out. Linus suggested this as far as I understood from the following: https://patchwork.kernel.org/patch/10016201/ If you use C++ comment style for the entire block, it will not stand out. -- Best Regards Masahiro Yamada
Powered by blists - more mailing lists