linux-kernel - Re: [PATCH V2] thermal/drivers/hisi: Switch to interrupt mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e86982ed-aa3f-118d-0c57-25b0ec905b4d@linaro.org>
Date:   Tue, 5 Dec 2017 07:49:45 +0100
From:   Daniel Lezcano <daniel.lezcano@...aro.org>
To:     Eduardo Valentin <edubezval@...il.com>
Cc:     Leo Yan <leo.yan@...aro.org>, rui.zhang@...el.com,
        jean.wangtao@...aro.org, Keerthy <j-keerthy@...com>,
        "open list:THERMAL" <linux-pm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V2] thermal/drivers/hisi: Switch to interrupt mode

On 05/12/2017 03:00, Eduardo Valentin wrote:
> Hello,
> 
> On Thu, Sep 28, 2017 at 09:32:20AM +0200, Daniel Lezcano wrote:
>> On Thu, Sep 28, 2017 at 02:57:52PM +0800, Leo Yan wrote:
>>> Hi Daniel,
>>>
>>> On Thu, Sep 28, 2017 at 07:13:44AM +0200, Daniel Lezcano wrote:
>>>> At this moment, we have both the interrupt setup and the polling enabled. The
>>>> interrupt does nothing more than forcing an update while the temperature is
>>>> polled every second.
>>>>
>>>> We can do much better than that, threshold is set to 65C in the DT and the
>>>> passive cooling device enters in the dance when 75C is reached. We need to
>>>> sample the temperature at 65C in order to let the IPA gather enough values for
>>>> the PID computation. If the SoC is running at a temperature below 65C, we will
>>>> be constantly polling for nothing.
>>>>
>>>> This patch disables the sensor when the temperature is below 65C and enables it
>>>> when passing the threshold. It results the thermal sensor driver will have no
>>>> activity most of the time.
>>>>
>>>> Cc: Keerthy <j-keerthy@...com>
>>>> Cc: Leo Yang <leo.yan@...aro.org>
>>>
>>> s/Yang/Yan :) Have tested this patch on Hikey at my side:
>>
>> Oops sorry :)
>>
>>> Reviewed-by: Leo Yan <leo.yan@...aro.org>
>>> Tested-by: Leo Yan <leo.yan@...aro.org>
>>
> 
> Is this still needed after the latest rework done?

No longer needed.



-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog