linux-kernel - Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171205105801.GV10595@n2100.armlinux.org.uk>
Date:   Tue, 5 Dec 2017 10:58:01 +0000
From:   Russell King - ARM Linux <linux@...linux.org.uk>
To:     Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:     David Miller <davem@...emloft.net>, arvind.yadav.cs@...il.com,
        f.fainelli@...il.com, netdev@...r.kernel.org,
        michal.simek@...inx.com, linux-kernel@...r.kernel.org,
        opendmb@...il.com, mkl@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org, wg@...ndegger.com
Subject: Re: [PATCH 4/7 v2] net: ethernet: i825xx: Fix platform_get_irq's
 error checking

On Tue, Dec 05, 2017 at 01:12:23PM +0300, Sergei Shtylyov wrote:
>    Well, we can have:
> 
> 	return r && r->start ? r->start : -ENXIO;
> 
> instead of:
> 
> 	return r ? r->start : -ENXIO;
> 
> at the end of platform_get_irq(). But I don't really think it's worth doing
> -- request_irq() doesn't filter out IRQ0 anyway, IIRC...

There's a bunch of platforms in the kernel that still use IRQ0, and
have done prior to Linus' comments on the subject.  Such a change
would regress them.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 8.8Mbps down 630kbps up
According to speedtest.net: 8.21Mbps down 510kbps up