linux-kernel - Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the standard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d68fa3d3-1280-b9ae-bf11-7784a73b1719@ti.com>
Date:   Tue, 5 Dec 2017 07:06:22 -0600
From:   Dan Murphy <dmurphy@...com>
To:     Rob Herring <robh@...nel.org>,
        Jacek Anaszewski <jacek.anaszewski@...il.com>
CC:     <rpurdie@...ys.net>, <pavel@....cz>, <linux-leds@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>
Subject: Re: [PATCH v6 4/6] dt: bindings: lp8860: Update the bindings to the
 standard

Rob

On 12/04/2017 04:35 PM, Rob Herring wrote:
> On Sun, Dec 03, 2017 at 02:27:20PM +0100, Jacek Anaszewski wrote:
>> Dan,
>>
>> On 12/01/2017 05:56 PM, Dan Murphy wrote:
>>> Update the lp8860 dt binding to the LED standard where
>>> the LED should have a child node and also adding a
>>> LED trigger entry.
>>>
>>> Signed-off-by: Dan Murphy <dmurphy@...com>
>>> ---
>>>
>>> v6 - New patch to fix binding documentation
>>>
>>>  Documentation/devicetree/bindings/leds/leds-lp8860.txt | 15 +++++++++++----
>>>  1 file changed, 11 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> index aad38dd94d4b..4cf396de6eba 100644
>>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>>> @@ -12,17 +12,24 @@ Required properties:
>>>  	- label - Used for naming LEDs
>>>  
>>>  Optional properties:
>>> -	- enable-gpio - gpio pin to enable/disable the device.
>>> -	- supply - "vled" - LED supply
>>> +	- enable-gpios : gpio pin to enable/disable the device.
>>> +	- vled-supply : LED supply
>>> +	- label : see Documentation/devicetree/bindings/leds/common.txt
>>> +	- linux,default-trigger : (optional)
>>> +	   see Documentation/devicetree/bindings/leds/common.txt
>>>  
>>>  Example:
>>>  
>>> -leds: leds@6 {
>>> +lp8860@2d {
> 
> leds@2d

Ack

> 
>>>  	compatible = "ti,lp8860";
>>>  	reg = <0x2d>;
>>> -	label = "display_cluster";
>>>  	enable-gpio = <&gpio1 28 GPIO_ACTIVE_HIGH>;
>>>  	vled-supply = <&vbatt>;
>>> +
>>> +	backlight: backlight@0 {
> 
> unit-address requires a 'reg' property. Building your dts files with W=1 
> will tell you this.

I will add this.  There is so much noise when enabling this option on the dts
I missed the warning.

Dan

<snip>

-- 
------------------
Dan Murphy