linux-kernel - Re: [PATCH v3 11/14] nubus: Rename struct nubus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <2621660.olL7LkYlpq@amdc3058>
Date:   Tue, 05 Dec 2017 14:50:55 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Finn Thain <fthain@...egraphics.com.au>
Cc:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        linux-m68k@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v3 11/14] nubus: Rename struct nubus_dev

On Tuesday, December 05, 2017 01:20:02 AM Finn Thain wrote:
> It is misleading to call a functional resource a "device". In adopting
> the Linux Driver Model, the struct device will be embedded in struct
> nubus_board. That will compound the terminlogy problem because drivers
> will bind with boards, not with functional resources. Avoid this by
> renaming struct nubus_dev as struct nubus_rsrc. "Functional resource"
> is the vendor's terminology so this helps avoid confusion.
> 
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Tested-by: Stan Johnson <userm57@...oo.com>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>

Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

for fbdev part

> ---
>  drivers/net/ethernet/8390/mac8390.c     |  26 ++++----
>  drivers/net/ethernet/natsemi/macsonic.c |  22 +++----
>  drivers/nubus/nubus.c                   | 105 ++++++++++++++++----------------
>  drivers/nubus/proc.c                    |  15 ++---
>  drivers/video/fbdev/macfb.c             |   2 +-
>  include/linux/nubus.h                   |  30 +++++----
>  6 files changed, 98 insertions(+), 102 deletions(-)

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics