linux-kernel - Re: [PATCH v3] pata_pdc2027x: Remove unnecessary error check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Dec 2017 14:59:44 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tj@...nel.org, sergei.shtylyov@...entembedded.com,
        linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH v3] pata_pdc2027x: Remove unnecessary error check

On Saturday, November 25, 2017 03:49:49 PM Arvind Yadav wrote:
> Here, The function pdc_hardware_init always return zero. So it is not
> necessary to check its return value.

Please fix pdc_adjust_pll() to return the error value instead.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics