linux-kernel - Re: [PATCH] pata_pdc2027x: Fix coding sytle error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 05 Dec 2017 15:12:08 +0100
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     tj@...nel.org, sergei.shtylyov@...entembedded.com,
        linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org
Subject: Re: [PATCH] pata_pdc2027x: Fix coding sytle error

On Tuesday, December 05, 2017 03:02:13 PM Bartlomiej Zolnierkiewicz wrote:
> On Saturday, November 25, 2017 04:04:07 PM Arvind Yadav wrote:
> > Fix these checkpatch.pl error:
> > ERROR: space prohibited before open square bracket '['.
> > 
> > ERROR: space prohibited after that '~' (ctx:WxW)
> > +		mask &= ~ (1 << (6 + ATA_SHIFT_UDMA));
> > 
> > ERROR: spaces required around that '?' (ctx:VxW)
> > +	long pout_required = board_idx? PDC_133_MHZ:PDC_100_MHZ;
> > 
> > ERROR: that open brace { should be on the previous line
> > +	const struct ata_port_info *ppi[] =
> > +		{ &pdc2027x_port_info[board_idx], NULL };
> > 
> > Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
> 
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

PS two small things than still can be fixed:

* s/sytle error/style errors/ in the patch summary

* s/error/errors/ in the patch description

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics