linux-kernel - Re: [PATCH v2 10/22] mmc: tmio: support IP-builtin card detection logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171205152839.czialo64b7nsgadu@ninjato>
Date:   Tue, 5 Dec 2017 16:28:39 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     linux-mmc <linux-mmc@...r.kernel.org>,
        Wolfram Sang <wsa+renesas@...g-engineering.com>,
        Simon Horman <simon.horman@...ronome.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        linux-renesas-soc@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Ulf Hansson <ulf.hansson@...aro.org>
Subject: Re: [PATCH v2 10/22] mmc: tmio: support IP-builtin card detection
 logic


> Another possibility would select this in _probe().
> We would need to evaluate mmc_can_gpio_cd() only once when probing.

I like this, too.

Maybe like this to be more obvious:

	if (mmc_can_gpio_cd(mmc))
		 _host->ops.get_cd = mmc_gpio_get_cd;
	else
		 _host->ops.get_cd = tmio...

?

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)